Re: [PATCH for-6.0] qapi: qom: do not use target-specific conditionals

2021-03-26 Thread Paolo Bonzini
On 26/03/21 13:27, Markus Armbruster wrote: ... until Kevin added some when he QAPIfied. Looks like this (copied from qemu-qmp-ref.7)[*]: SevGuestProperties (Object) Properties for sev-guest objects. Members sev-device: string (optional) SEV device to use

Re: [PATCH for-6.0] qapi: qom: do not use target-specific conditionals

2021-03-26 Thread Tom Lendacky
On 3/26/21 5:03 AM, Paolo Bonzini wrote: > ObjectType and ObjectOptions are defined in a target-independent file, > therefore they do not have access to target-specific configuration > symbols such as CONFIG_PSERIES or CONFIG_SEV. For this reason, > pef-guest and sev-guest are currently omitted wh

Re: [PATCH for-6.0] qapi: qom: do not use target-specific conditionals

2021-03-26 Thread Markus Armbruster
Paolo Bonzini writes: > On 26/03/21 11:57, Markus Armbruster wrote: >>> 'rng-random': 'RngRandomProperties', >>> 'secret': 'SecretProperties', >>> 'secret_keyring': 'SecretKeyringProperties', >>> - 'sev-guest':

Re: [PATCH for-6.0] qapi: qom: do not use target-specific conditionals

2021-03-26 Thread Paolo Bonzini
On 26/03/21 11:57, Markus Armbruster wrote: 'rng-random': 'RngRandomProperties', 'secret': 'SecretProperties', 'secret_keyring': 'SecretKeyringProperties', - 'sev-guest': { 'type': 'SevGuestProperties',

Re: [PATCH for-6.0] qapi: qom: do not use target-specific conditionals

2021-03-26 Thread Markus Armbruster
Paolo Bonzini writes: > ObjectType and ObjectOptions are defined in a target-independent file, > therefore they do not have access to target-specific configuration > symbols such as CONFIG_PSERIES or CONFIG_SEV. For this reason, > pef-guest and sev-guest are currently omitted when compiling the

[PATCH for-6.0] qapi: qom: do not use target-specific conditionals

2021-03-26 Thread Paolo Bonzini
ObjectType and ObjectOptions are defined in a target-independent file, therefore they do not have access to target-specific configuration symbols such as CONFIG_PSERIES or CONFIG_SEV. For this reason, pef-guest and sev-guest are currently omitted when compiling the generated QAPI files. In additi