Re: [PATCH for-6.0] hw/timer/renesas_tmr: Add default-case asserts in read_tcnt()

2021-04-01 Thread Yoshinori Sato
On Sat, 20 Mar 2021 01:24:58 +0900, Peter Maydell wrote: > > In commit 81b3ddaf8772ec we fixed a use of uninitialized data > in read_tcnt(). However this change wasn't enough to placate > Coverity, which is not smart enough to see that if we read a > 2 bit field and then handle cases 0, 1, 2 and 3

Re: [PATCH for-6.0] hw/timer/renesas_tmr: Add default-case asserts in read_tcnt()

2021-03-29 Thread Peter Maydell
On Mon, 29 Mar 2021 at 18:03, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > If you are preparing a qemu-arm pull request, can you > squeeze this patch in? Yep, that was my plan. thanks -- PMM

Re: [PATCH for-6.0] hw/timer/renesas_tmr: Add default-case asserts in read_tcnt()

2021-03-29 Thread Philippe Mathieu-Daudé
Hi Peter, If you are preparing a qemu-arm pull request, can you squeeze this patch in? On 3/26/21 7:49 PM, Philippe Mathieu-Daudé wrote: > On 3/26/21 2:34 PM, Peter Maydell wrote: >> ping for review? > > FYI: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg790977.html > >> On Fri, 19 Ma

Re: [PATCH for-6.0] hw/timer/renesas_tmr: Add default-case asserts in read_tcnt()

2021-03-26 Thread Philippe Mathieu-Daudé
On 3/26/21 2:34 PM, Peter Maydell wrote: > ping for review? FYI: https://www.mail-archive.com/qemu-devel@nongnu.org/msg790977.html > On Fri, 19 Mar 2021 at 16:24, Peter Maydell wrote: >> >> In commit 81b3ddaf8772ec we fixed a use of uninitialized data >> in read_tcnt(). However this change wasn'

Re: [PATCH for-6.0] hw/timer/renesas_tmr: Add default-case asserts in read_tcnt()

2021-03-26 Thread Peter Maydell
ping for review? thanks -- PMM On Fri, 19 Mar 2021 at 16:24, Peter Maydell wrote: > > In commit 81b3ddaf8772ec we fixed a use of uninitialized data > in read_tcnt(). However this change wasn't enough to placate > Coverity, which is not smart enough to see that if we read a > 2 bit field and then

[PATCH for-6.0] hw/timer/renesas_tmr: Add default-case asserts in read_tcnt()

2021-03-19 Thread Peter Maydell
In commit 81b3ddaf8772ec we fixed a use of uninitialized data in read_tcnt(). However this change wasn't enough to placate Coverity, which is not smart enough to see that if we read a 2 bit field and then handle cases 0, 1, 2 and 3 then there cannot be a flow of execution through the switch default