Re: [PATCH for-5.2 3/4] qtest: escape device name in device-introspect-test

2020-11-06 Thread Markus Armbruster
Paolo Bonzini writes: > On 06/11/20 14:15, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> device-introspect-test uses HMP, so it should escape the device name >>> properly. Because of this, a few devices that had commas in their >>> names were escaping testing. >>> Signed-off-by: Pao

Re: [PATCH for-5.2 3/4] qtest: escape device name in device-introspect-test

2020-11-06 Thread Paolo Bonzini
On 06/11/20 14:15, Markus Armbruster wrote: Paolo Bonzini writes: device-introspect-test uses HMP, so it should escape the device name properly. Because of this, a few devices that had commas in their names were escaping testing. Signed-off-by: Paolo Bonzini $ git-grep '\.name *= *"[^"]*,'

Re: [PATCH for-5.2 3/4] qtest: escape device name in device-introspect-test

2020-11-06 Thread Markus Armbruster
Paolo Bonzini writes: > device-introspect-test uses HMP, so it should escape the device name > properly. Because of this, a few devices that had commas in their > names were escaping testing. > Signed-off-by: Paolo Bonzini $ git-grep '\.name *= *"[^"]*,' | cat hw/block/fdc.c:.name

Re: [PATCH for-5.2 3/4] qtest: escape device name in device-introspect-test

2020-11-04 Thread Paolo Bonzini
I will just drop autofree usage completely, also because valgrind showed that GRegex does not support it and apparently is leaked. Paolo Il mer 4 nov 2020, 08:44 Thomas Huth ha scritto: > On 03/11/2020 16.14, Paolo Bonzini wrote: > > device-introspect-test uses HMP, so it should escape the devi

Re: [PATCH for-5.2 3/4] qtest: escape device name in device-introspect-test

2020-11-03 Thread Thomas Huth
On 03/11/2020 16.14, Paolo Bonzini wrote: > device-introspect-test uses HMP, so it should escape the device name > properly. Because of this, a few devices that had commas in their > names were escaping testing. > > Signed-off-by: Paolo Bonzini > --- > tests/qtest/device-introspect-test.c | 9 +

[PATCH for-5.2 3/4] qtest: escape device name in device-introspect-test

2020-11-03 Thread Paolo Bonzini
device-introspect-test uses HMP, so it should escape the device name properly. Because of this, a few devices that had commas in their names were escaping testing. Signed-off-by: Paolo Bonzini --- tests/qtest/device-introspect-test.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-