Re: [PATCH for-5.2 1/3] linux-user/sparc: Fix errors in target_ucontext structures

2020-11-10 Thread Laurent Vivier
Le 10/11/2020 à 10:02, LemonBoy a écrit : > Hello Laurent, > you probably want to also apply my patch for stack_t definitions [1] that > was mentioned in Peter Maydell's cover letter for the patch series. > > [1] https://patchew.org/QEMU/e9d47692-ee92-009f-6007-0abc3f502...@gmail.com/ Yes, you're

Re: [PATCH for-5.2 1/3] linux-user/sparc: Fix errors in target_ucontext structures

2020-11-10 Thread LemonBoy
Hello Laurent, you probably want to also apply my patch for stack_t definitions [1] that was mentioned in Peter Maydell's cover letter for the patch series. [1] https://patchew.org/QEMU/e9d47692-ee92-009f-6007-0abc3f502...@gmail.com/ On 10/11/20 07:53, Laurent Vivier wrote: > Le 05/11/2020 à 22:2

Re: [PATCH for-5.2 1/3] linux-user/sparc: Fix errors in target_ucontext structures

2020-11-09 Thread Laurent Vivier
Le 05/11/2020 à 22:23, Peter Maydell a écrit : > The various structs that make up the SPARC target_ucontext had some > errors: > * target structures must not include fields which are host pointers, >which might be the wrong size. These should be abi_ulong instead > * because we don't have th

Re: [PATCH for-5.2 1/3] linux-user/sparc: Fix errors in target_ucontext structures

2020-11-05 Thread Peter Maydell
On Thu, 5 Nov 2020 at 22:15, Richard Henderson wrote: > > On 11/5/20 1:23 PM, Peter Maydell wrote: > > +} __attribute__((aligned(16))); > > Hmph, 96 uses of the attribute directly, 20 uses of QEMU_ALIGNED. I suppose > we > should just remove the wrapper... Oops, I forget about that. We're bette

Re: [PATCH for-5.2 1/3] linux-user/sparc: Fix errors in target_ucontext structures

2020-11-05 Thread Richard Henderson
On 11/5/20 1:23 PM, Peter Maydell wrote: > The various structs that make up the SPARC target_ucontext had some > errors: > * target structures must not include fields which are host pointers, >which might be the wrong size. These should be abi_ulong instead > * because we don't have the 'lon

[PATCH for-5.2 1/3] linux-user/sparc: Fix errors in target_ucontext structures

2020-11-05 Thread Peter Maydell
The various structs that make up the SPARC target_ucontext had some errors: * target structures must not include fields which are host pointers, which might be the wrong size. These should be abi_ulong instead * because we don't have the 'long double' part of the mcfpu_fregs union in our v