Re: [PATCH for-5.2 05/10] vhost-user-blk-test: close fork child file descriptors

2020-12-18 Thread Coiby Xu
On Thu, Dec 03, 2020 at 01:57:21PM +, Stefan Hajnoczi wrote: On Tue, Nov 24, 2020 at 08:08:26PM +0800, Coiby Xu wrote: Hi Stefan, On Wed, Nov 11, 2020 at 12:43:26PM +, Stefan Hajnoczi wrote: > Do not leave stdin and stdout open after fork. stdout is the > tap-driver.pl pipe. If we keep

Re: [PATCH for-5.2 05/10] vhost-user-blk-test: close fork child file descriptors

2020-12-03 Thread Stefan Hajnoczi
On Tue, Nov 24, 2020 at 08:08:26PM +0800, Coiby Xu wrote: > Hi Stefan, > > On Wed, Nov 11, 2020 at 12:43:26PM +, Stefan Hajnoczi wrote: > > Do not leave stdin and stdout open after fork. stdout is the > > tap-driver.pl pipe. If we keep the pipe open then tap-driver.pl will not > > detect that

Re: [PATCH for-5.2 05/10] vhost-user-blk-test: close fork child file descriptors

2020-11-24 Thread Coiby Xu
Hi Stefan, On Wed, Nov 11, 2020 at 12:43:26PM +, Stefan Hajnoczi wrote: Do not leave stdin and stdout open after fork. stdout is the tap-driver.pl pipe. If we keep the pipe open then tap-driver.pl will not detect that qos-test has terminated and it will hang. I wonder under which situation

[PATCH for-5.2 05/10] vhost-user-blk-test: close fork child file descriptors

2020-11-11 Thread Stefan Hajnoczi
Do not leave stdin and stdout open after fork. stdout is the tap-driver.pl pipe. If we keep the pipe open then tap-driver.pl will not detect that qos-test has terminated and it will hang. Signed-off-by: Stefan Hajnoczi --- tests/qtest/vhost-user-blk-test.c | 9 + 1 file changed, 9 insert