Re: [PATCH for-5.2] vhost-user: fix VHOST_USER_ADD/REM_MEM_REG truncation

2020-11-10 Thread Stefan Hajnoczi
On Mon, Nov 09, 2020 at 06:59:00PM +0100, Cornelia Huck wrote: > On Mon, 9 Nov 2020 17:43:55 + > Stefan Hajnoczi wrote: > > Fixes: f1aeb14b0809e313c74244d838645ed25e85ea63 ("Transmit vhost-user > > memory regions individually") > > I think the canonical format is > > Fixes: f1aeb14b0809 ("

Re: [PATCH for-5.2] vhost-user: fix VHOST_USER_ADD/REM_MEM_REG truncation

2020-11-09 Thread Raphael Norwitz
On Mon, Nov 9, 2020 at 12:59 PM Stefan Hajnoczi wrote: > > QEMU currently truncates the mmap_offset field when sending > VHOST_USER_ADD_MEM_REG and VHOST_USER_REM_MEM_REG messages. The struct > layout looks like this: > > typedef struct VhostUserMemoryRegion { > uint64_t guest_phys_addr; >

Re: [PATCH for-5.2] vhost-user: fix VHOST_USER_ADD/REM_MEM_REG truncation

2020-11-09 Thread Cornelia Huck
On Mon, 9 Nov 2020 17:43:55 + Stefan Hajnoczi wrote: > QEMU currently truncates the mmap_offset field when sending > VHOST_USER_ADD_MEM_REG and VHOST_USER_REM_MEM_REG messages. The struct > layout looks like this: > > typedef struct VhostUserMemoryRegion { > uint64_t guest_phys_addr

[PATCH for-5.2] vhost-user: fix VHOST_USER_ADD/REM_MEM_REG truncation

2020-11-09 Thread Stefan Hajnoczi
QEMU currently truncates the mmap_offset field when sending VHOST_USER_ADD_MEM_REG and VHOST_USER_REM_MEM_REG messages. The struct layout looks like this: typedef struct VhostUserMemoryRegion { uint64_t guest_phys_addr; uint64_t memory_size; uint64_t userspace_addr; uint6