Re: [PATCH for-5.1] hw: Only compile the usb-dwc2 controller if it is really needed

2020-07-24 Thread Gerd Hoffmann
On Wed, Jul 22, 2020 at 09:36:27PM -0700, Paul Zimmerman wrote: > Gerd, it's OK by me if you take Thomas's patch instead, I agree the > changelog is better. It also has a fixes tag. > > Reviewed-by: Paul Zimmerman Queued. Thanks, Gerd

Re: [PATCH for-5.1] hw: Only compile the usb-dwc2 controller if it is really needed

2020-07-22 Thread Paul Zimmerman
Gerd, it's OK by me if you take Thomas's patch instead, I agree the changelog is better. It also has a fixes tag. Reviewed-by: Paul Zimmerman On Wed, Jul 22, 2020 at 9:29 PM Thomas Huth wrote: > On 22/07/2020 19.23, Philippe Mathieu-Daudé wrote: > > On 7/22/20 5:47 PM, Thomas Huth wrote: > >>

Re: [PATCH for-5.1] hw: Only compile the usb-dwc2 controller if it is really needed

2020-07-22 Thread Thomas Huth
On 22/07/2020 19.23, Philippe Mathieu-Daudé wrote: > On 7/22/20 5:47 PM, Thomas Huth wrote: >> The USB_DWC2 switch is currently "default y", so it is included in all >> qemu-system-* builds, even if it is not needed. Even worse, it does a >> "select USB", so USB devices are now showing up as availa

Re: [PATCH for-5.1] hw: Only compile the usb-dwc2 controller if it is really needed

2020-07-22 Thread Philippe Mathieu-Daudé
On 7/22/20 5:47 PM, Thomas Huth wrote: > The USB_DWC2 switch is currently "default y", so it is included in all > qemu-system-* builds, even if it is not needed. Even worse, it does a > "select USB", so USB devices are now showing up as available on targets > that do not support USB at all. This sy

[PATCH for-5.1] hw: Only compile the usb-dwc2 controller if it is really needed

2020-07-22 Thread Thomas Huth
The USB_DWC2 switch is currently "default y", so it is included in all qemu-system-* builds, even if it is not needed. Even worse, it does a "select USB", so USB devices are now showing up as available on targets that do not support USB at all. This sysbus device should only be included by the boar