Re: [PATCH for-5.0] dump: Fix writing of ELF section

2020-04-06 Thread Peter Maydell
I forgot to cc qemu-stable, so doing that now (I've also added the Cc: tag to the commit message for when I send this in the target-arm pullreq today); for the record, the Coverity id is CID 1421970 (also added to the commit message). thanks -- PMM On Tue, 24 Mar 2020 at 17:36, Peter Maydell wro

Re: [PATCH for-5.0] dump: Fix writing of ELF section

2020-04-04 Thread Peter Maydell
On Fri, 3 Apr 2020 at 21:55, Philippe Mathieu-Daudé wrote: > > On 3/24/20 6:36 PM, Peter Maydell wrote: > > In write_elf_section() we set the 'shdr' pointer to point to local > > structures shdr32 or shdr64, which we fill in to be written out to > > the ELF dump. Unfortunately the address we pass

Re: [PATCH for-5.0] dump: Fix writing of ELF section

2020-04-03 Thread Philippe Mathieu-Daudé
On 3/24/20 6:36 PM, Peter Maydell wrote: In write_elf_section() we set the 'shdr' pointer to point to local structures shdr32 or shdr64, which we fill in to be written out to the ELF dump. Unfortunately the address we pass to fd_write_vmcore() has a spurious '&' operator, so instead of writing o

Re: [PATCH for-5.0] dump: Fix writing of ELF section

2020-04-03 Thread Peter Maydell
On Tue, 24 Mar 2020 at 17:49, Marc-André Lureau wrote: > > Hi > > On Tue, Mar 24, 2020 at 6:36 PM Peter Maydell > wrote: > > > > In write_elf_section() we set the 'shdr' pointer to point to local > > structures shdr32 or shdr64, which we fill in to be written out to > > the ELF dump. Unfortunat

Re: [PATCH for-5.0] dump: Fix writing of ELF section

2020-03-24 Thread Marc-André Lureau
Hi On Tue, Mar 24, 2020 at 6:36 PM Peter Maydell wrote: > > In write_elf_section() we set the 'shdr' pointer to point to local > structures shdr32 or shdr64, which we fill in to be written out to > the ELF dump. Unfortunately the address we pass to fd_write_vmcore() > has a spurious '&' operator

Re: [PATCH for-5.0] dump: Fix writing of ELF section

2020-03-24 Thread Peter Maydell
On Tue, 24 Mar 2020 at 17:36, Peter Maydell wrote: > > In write_elf_section() we set the 'shdr' pointer to point to local > structures shdr32 or shdr64, which we fill in to be written out to > the ELF dump. Unfortunately the address we pass to fd_write_vmcore() > has a spurious '&' operator, so i

[PATCH for-5.0] dump: Fix writing of ELF section

2020-03-24 Thread Peter Maydell
In write_elf_section() we set the 'shdr' pointer to point to local structures shdr32 or shdr64, which we fill in to be written out to the ELF dump. Unfortunately the address we pass to fd_write_vmcore() has a spurious '&' operator, so instead of writing out the section header we write out the lite