+void vfio_migration_set_error(int ret)
+{
+if (migration_is_running()) {
+migration_file_set_error(ret, NULL);
+}
+}
--
* The change looks okay. But with the 'Error *err = NULL' parameter,
the error (ret) is also not passed on. Could we call
migration_file_set_error(ret, errp
On Fri, 21 Mar 2025 at 15:49, Cédric Le Goater wrote:
> So you mean open coding :
> if (migration_is_running()) {
> migration_file_set_error(ret, errp);
> }
> ?
* Yes.
> Yes. I think it is a good idea to limit proliferation of this wrapper.
> Ideally, we wouldn't need to use m
On Tue, Mar 18, 2025 at 10:54:08AM +0100, Cédric Le Goater wrote:
> This routine is related to VFIO migration. It belongs to "migration.c".
> While at it, rename it to better reflect the namespace it belongs to.
>
> Signed-off-by: Cédric Le Goater
Reviewed-by: John Levon
regards
john
On Tue, 18 Mar 2025 at 15:29, Cédric Le Goater wrote:
> This routine is related to VFIO migration. It belongs to "migration.c".
> While at it, rename it to better reflect the namespace it belongs to.
>
> Signed-off-by: Cédric Le Goater
> ---
> hw/vfio/migration.h | 1 +
> hw/vfio/dirty-tra
This routine is related to VFIO migration. It belongs to "migration.c".
While at it, rename it to better reflect the namespace it belongs to.
Signed-off-by: Cédric Le Goater
---
hw/vfio/migration.h | 1 +
hw/vfio/dirty-tracking.c | 19 +--
hw/vfio/migration.c | 7
