Re: [PATCH for-10.0] scsi-disk: Apply error policy for host_status errors again

2025-05-13 Thread Kevin Wolf
Am 10.04.2025 um 15:33 hat Michael Tokarev geschrieben: > 10.04.2025 16:14, Kevin Wolf wrote: > > Am 10.04.2025 um 14:37 hat Michael Tokarev geschrieben: > ...>> Does it make sense to apply this one for older stable qemu series? > > > In particular, in 8.2, we lack cfe0880835cd3 > > > "scsi-disk: U

Re: [PATCH for-10.0] scsi-disk: Apply error policy for host_status errors again

2025-05-13 Thread Michael Tokarev
On 13.05.2025 14:42, Kevin Wolf wrote: Am 12.05.2025 um 11:23 hat Michael Tokarev geschrieben: [..] This was already merged for 10.0 as commit 61b6d9b7. Heck. Yes, it is, and I already queued it for 9.2, too. Sorry for the noise. /mjt

Re: [PATCH for-10.0] scsi-disk: Apply error policy for host_status errors again

2025-05-13 Thread Kevin Wolf
Am 12.05.2025 um 11:23 hat Michael Tokarev geschrieben: > On 07.04.2025 18:59, Kevin Wolf wrote: > > Originally, all failed SG_IO requests called scsi_handle_rw_error() to > > apply the configured error policy. However, commit f3126d65, which was > > supposed to be a mere refactoring for scsi-disk.

Re: [PATCH for-10.0] scsi-disk: Apply error policy for host_status errors again

2025-05-12 Thread Michael Tokarev
On 07.04.2025 18:59, Kevin Wolf wrote: Originally, all failed SG_IO requests called scsi_handle_rw_error() to apply the configured error policy. However, commit f3126d65, which was supposed to be a mere refactoring for scsi-disk.c, broke this and accidentally completed the SCSI request without co

Re: [PATCH for-10.0] scsi-disk: Apply error policy for host_status errors again

2025-04-11 Thread Paolo Bonzini
On Fri, Apr 11, 2025 at 12:18 PM Kevin Wolf wrote: > > Okay, going down the scsi_sense_from_errno() path is more or less > > harmless because status and sense end up unused; even though ENODEV is > > not something that the function handles, that can be added as a > > cleanup in 10.1. > > Yes, it c

Re: [PATCH for-10.0] scsi-disk: Apply error policy for host_status errors again

2025-04-11 Thread Kevin Wolf
Am 10.04.2025 um 17:28 hat Paolo Bonzini geschrieben: > On Thu, Apr 10, 2025 at 4:25 PM Paolo Bonzini wrote: > > You should set ret = 0 here to avoid going down the > > scsi_sense_from_errno() path. > > > > Otherwise, > > > > Reviewed-by: Paolo Bonzini > > Okay, going down the scsi_sense_from_er

[PATCH for-10.0] scsi-disk: Apply error policy for host_status errors again

2025-04-10 Thread Kevin Wolf
Originally, all failed SG_IO requests called scsi_handle_rw_error() to apply the configured error policy. However, commit f3126d65, which was supposed to be a mere refactoring for scsi-disk.c, broke this and accidentally completed the SCSI request without considering the error policy any more if th

Re: [PATCH for-10.0] scsi-disk: Apply error policy for host_status errors again

2025-04-10 Thread Michael Tokarev
10.04.2025 16:14, Kevin Wolf wrote: Am 10.04.2025 um 14:37 hat Michael Tokarev geschrieben: ...>> Does it make sense to apply this one for older stable qemu series? In particular, in 8.2, we lack cfe0880835cd3 "scsi-disk: Use positive return value for status in dma_readv/writev", which seems to

Re: [PATCH for-10.0] scsi-disk: Apply error policy for host_status errors again

2025-04-10 Thread Paolo Bonzini
On Thu, Apr 10, 2025 at 4:25 PM Paolo Bonzini wrote: > You should set ret = 0 here to avoid going down the > scsi_sense_from_errno() path. > > Otherwise, > > Reviewed-by: Paolo Bonzini Okay, going down the scsi_sense_from_errno() path is more or less harmless because status and sense end up unus

Re: [PATCH for-10.0] scsi-disk: Apply error policy for host_status errors again

2025-04-10 Thread Paolo Bonzini
On 4/7/25 17:59, Kevin Wolf wrote: Originally, all failed SG_IO requests called scsi_handle_rw_error() to apply the configured error policy. However, commit f3126d65, which was supposed to be a mere refactoring for scsi-disk.c, broke this and accidentally completed the SCSI request without consid

Re: [PATCH for-10.0] scsi-disk: Apply error policy for host_status errors again

2025-04-10 Thread Kevin Wolf
Am 10.04.2025 um 14:37 hat Michael Tokarev geschrieben: > 07.04.2025 18:59, Kevin Wolf пишет: > > Originally, all failed SG_IO requests called scsi_handle_rw_error() to > > apply the configured error policy. However, commit f3126d65, which was > > supposed to be a mere refactoring for scsi-disk.c,

Re: [PATCH for-10.0] scsi-disk: Apply error policy for host_status errors again

2025-04-10 Thread Michael Tokarev
07.04.2025 18:59, Kevin Wolf пишет: Originally, all failed SG_IO requests called scsi_handle_rw_error() to apply the configured error policy. However, commit f3126d65, which was supposed to be a mere refactoring for scsi-disk.c, broke this and accidentally completed the SCSI request without consi

Re: [PATCH for-10.0] scsi-disk: Apply error policy for host_status errors again

2025-04-08 Thread Hanna Czenczek
On 07.04.25 17:59, Kevin Wolf wrote: Originally, all failed SG_IO requests called scsi_handle_rw_error() to apply the configured error policy. However, commit f3126d65, which was supposed to be a mere refactoring for scsi-disk.c, broke this and accidentally completed the SCSI request without cons

Re: [PATCH for-10.0] scsi-disk: Apply error policy for host_status errors again

2025-04-07 Thread Stefan Hajnoczi
On Mon, Apr 7, 2025 at 12:00 PM Kevin Wolf wrote: > > Originally, all failed SG_IO requests called scsi_handle_rw_error() to > apply the configured error policy. However, commit f3126d65, which was > supposed to be a mere refactoring for scsi-disk.c, broke this and > accidentally completed the SCS