Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables

2023-02-16 Thread Sunil V L
On Thu, Feb 16, 2023 at 08:26:21AM -0800, Palmer Dabbelt wrote: > On Wed, 15 Feb 2023 06:08:10 PST (-0800), suni...@ventanamicro.com wrote: > > On Tue, Feb 14, 2023 at 05:44:44AM -0300, Daniel Henrique Barboza wrote: > > > > > > > > > On 2/14/23 00:43, Sunil V L wrote: > > > > On Mon, Feb 13, 202

Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables

2023-02-16 Thread Palmer Dabbelt
On Wed, 15 Feb 2023 06:08:10 PST (-0800), suni...@ventanamicro.com wrote: On Tue, Feb 14, 2023 at 05:44:44AM -0300, Daniel Henrique Barboza wrote: On 2/14/23 00:43, Sunil V L wrote: > On Mon, Feb 13, 2023 at 03:48:04PM -0300, Daniel Henrique Barboza wrote: Nah. Doing that now will make this s

Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables

2023-02-15 Thread Sunil V L
On Tue, Feb 14, 2023 at 05:44:44AM -0300, Daniel Henrique Barboza wrote: > > > On 2/14/23 00:43, Sunil V L wrote: > > On Mon, Feb 13, 2023 at 03:48:04PM -0300, Daniel Henrique Barboza wrote: > > Nah. Doing that now will make this series rely on acks for every other ACPI > arch to > push the RIS

Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables

2023-02-15 Thread Andrew Jones
On Mon, Feb 13, 2023 at 08:10:32PM +0530, Sunil V L wrote: > Add few basic ACPI tables and DSDT with few devices in a > new file virt-acpi-build.c. > > These are mostly leveraged from arm64. > > Signed-off-by: Sunil V L > --- > hw/riscv/virt-acpi-build.c | 285 ++

Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables

2023-02-14 Thread Andrew Jones
On Tue, Feb 14, 2023 at 09:13:28AM +0530, Sunil V L wrote: > On Mon, Feb 13, 2023 at 03:48:04PM -0300, Daniel Henrique Barboza wrote: > > Sunil, > > > > This patch is a bit confusing to me. You're using functions that doesn't > > exist > > in the code base yet (build_madt and build_rhct) because

Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables

2023-02-14 Thread Bin Meng
On Tue, Feb 14, 2023 at 11:43 AM Sunil V L wrote: > > On Mon, Feb 13, 2023 at 03:48:04PM -0300, Daniel Henrique Barboza wrote: > > Sunil, > > > > This patch is a bit confusing to me. You're using functions that doesn't > > exist > > in the code base yet (build_madt and build_rhct) because they ar

Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables

2023-02-14 Thread Sunil V L
On Mon, Feb 13, 2023 at 03:48:04PM -0300, Daniel Henrique Barboza wrote: > Sunil, > > This patch is a bit confusing to me. You're using functions that doesn't exist > in the code base yet (build_madt and build_rhct) because they are introduced > in later patches. This also means that this patch is

Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables

2023-02-14 Thread Daniel Henrique Barboza
On 2/14/23 00:43, Sunil V L wrote: On Mon, Feb 13, 2023 at 03:48:04PM -0300, Daniel Henrique Barboza wrote: Sunil, This patch is a bit confusing to me. You're using functions that doesn't exist in the code base yet (build_madt and build_rhct) because they are introduced in later patches. Thi

Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables

2023-02-13 Thread Daniel Henrique Barboza
Sunil, This patch is a bit confusing to me. You're using functions that doesn't exist in the code base yet (build_madt and build_rhct) because they are introduced in later patches. This also means that this patch is not being compiled tested, because otherwise it would throw a compile error. And

[PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables

2023-02-13 Thread Sunil V L
Add few basic ACPI tables and DSDT with few devices in a new file virt-acpi-build.c. These are mostly leveraged from arm64. Signed-off-by: Sunil V L --- hw/riscv/virt-acpi-build.c | 285 + include/hw/riscv/virt.h| 1 + 2 files changed, 286 insertions(+)