Re: [PATCH V2] vhost-user-blk/scsi: Fix broken error handling for socket call

2020-11-14 Thread Michael S. Tsirkin
On Thu, Oct 29, 2020 at 02:03:52PM +0800, AlexChen wrote: > When socket() fails, it returns -1, 0 is the normal return value and should > not return error. > > Reported-by: Euler Robot > Signed-off-by: AlexChen Tagged, thanks! > --- > contrib/vhost-user-blk/vhost-user-blk.c | 2 +- > contr

Re: [PATCH V2] vhost-user-blk/scsi: Fix broken error handling for socket call

2020-11-12 Thread Peter Maydell
Ping? This is a coverity issue fix which has been reviewed, whose tree should it go via? Adding mst to cc list as the listed maintainer. thanks -- PMM On Thu, 29 Oct 2020 at 06:05, AlexChen wrote: > > When socket() fails, it returns -1, 0 is the normal return value and should > not return erro

Re: [PATCH V2] vhost-user-blk/scsi: Fix broken error handling for socket call

2020-10-29 Thread Raphael Norwitz
On Thu, Oct 29, 2020 at 2:04 AM AlexChen wrote: > > When socket() fails, it returns -1, 0 is the normal return value and should > not return error. > > Reported-by: Euler Robot > Signed-off-by: AlexChen Reviewed-by: Raphael Norwitz > --- > contrib/vhost-user-blk/vhost-user-blk.c | 2 +- >

[PATCH V2] vhost-user-blk/scsi: Fix broken error handling for socket call

2020-10-28 Thread AlexChen
When socket() fails, it returns -1, 0 is the normal return value and should not return error. Reported-by: Euler Robot Signed-off-by: AlexChen --- contrib/vhost-user-blk/vhost-user-blk.c | 2 +- contrib/vhost-user-scsi/vhost-user-scsi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-