On 2/7/2023 4:29 PM, Peter Xu wrote:
> On Tue, Feb 07, 2023 at 04:17:34PM -0500, Steven Sistare wrote:
+ * *@reasonp is freed and set to NULL if failure is returned.
+ * On success, the caller no longer owns *@reasonp and must not free it.
>>>
>>> This statement reads weird. IMHO the cal
On Tue, Feb 07, 2023 at 04:17:34PM -0500, Steven Sistare wrote:
> >> + * *@reasonp is freed and set to NULL if failure is returned.
> >> + * On success, the caller no longer owns *@reasonp and must not free it.
> >
> > This statement reads weird. IMHO the caller still owns @reasonp, but if it
> >
On 2/7/2023 3:05 PM, Peter Xu wrote:
> On Tue, Feb 07, 2023 at 11:03:13AM -0800, Steve Sistare wrote:
>> Modify migrate_add_blocker and migrate_del_blocker to take an Error **
>> reason. This allows migration to own the Error object, so that if
>> an error occurs, migration code can free the Error
On Tue, Feb 07, 2023 at 11:03:13AM -0800, Steve Sistare wrote:
> Modify migrate_add_blocker and migrate_del_blocker to take an Error **
> reason. This allows migration to own the Error object, so that if
> an error occurs, migration code can free the Error and clear the client
> handle, simplifyin
Modify migrate_add_blocker and migrate_del_blocker to take an Error **
reason. This allows migration to own the Error object, so that if
an error occurs, migration code can free the Error and clear the client
handle, simplifying client code. This is a pre-requisite for a future
patch that will al
