Re: [PATCH V2] hw/display/omap_lcdc: Fix potential NULL pointer dereference

2020-11-02 Thread Peter Maydell
On Sat, 31 Oct 2020 at 03:35, AlexChen wrote: > > In omap_lcd_interrupts(), the pointer omap_lcd is dereferinced before > being check if it is valid, which may lead to NULL pointer dereference. > So move the assignment to surface after checking that the omap_lcd is valid > and move surface_bits_pe

[PATCH V2] hw/display/omap_lcdc: Fix potential NULL pointer dereference

2020-10-30 Thread AlexChen
In omap_lcd_interrupts(), the pointer omap_lcd is dereferinced before being check if it is valid, which may lead to NULL pointer dereference. So move the assignment to surface after checking that the omap_lcd is valid and move surface_bits_per_pixel(surface) to after the surface assignment. Report