Re: [PATCH V15 1/6] target/mips: Fix PageMask with variable page size

2020-10-29 Thread chen huacai
Hi, Richard, On Wed, Oct 28, 2020 at 4:48 PM Richard Henderson wrote: > > On 10/27/20 9:17 PM, Huacai Chen wrote: > > +invalid: > > +/* > > + * When invalid, ensure the value is bigger than or equal to > > + * the minimal but smaller than or equal to the maxium. > > + */ > > +

Re: [PATCH V15 1/6] target/mips: Fix PageMask with variable page size

2020-10-28 Thread Richard Henderson
On 10/27/20 9:17 PM, Huacai Chen wrote: > +invalid: > +/* > + * When invalid, ensure the value is bigger than or equal to > + * the minimal but smaller than or equal to the maxium. > + */ > +maskbits = MIN(16, MAX(maskbits, TARGET_PAGE_BITS - 12)); > +env->CP0_PageMask = ((1

[PATCH V15 1/6] target/mips: Fix PageMask with variable page size

2020-10-27 Thread Huacai Chen
From: Jiaxun Yang Our current code assumed the target page size is always 4k when handling PageMask and VPN2, however, variable page size was just added to mips target and that's no longer true. Fixes: ee3863b9d414 ("target/mips: Support variable page size") Signed-off-by: Jiaxun Yang Signed-of