Re: [PATCH RFC v2 06/13] virtio-pci: implement support for extended features

2025-07-16 Thread Akihiko Odaki
On 2025/07/16 18:14, Paolo Abeni wrote: On 7/15/25 6:21 PM, Paolo Abeni wrote: On 7/15/25 9:42 AM, Akihiko Odaki wrote: On 2025/07/11 22:02, Paolo Abeni wrote: @@ -158,7 +159,10 @@ struct VirtIOPCIProxy { uint32_t nvectors; uint32_t dfselect; uint32_t gfselect; -uint32

Re: [PATCH RFC v2 06/13] virtio-pci: implement support for extended features

2025-07-16 Thread Paolo Abeni
On 7/15/25 6:21 PM, Paolo Abeni wrote: > On 7/15/25 9:42 AM, Akihiko Odaki wrote: >> On 2025/07/11 22:02, Paolo Abeni wrote: >>> @@ -158,7 +159,10 @@ struct VirtIOPCIProxy { >>> uint32_t nvectors; >>> uint32_t dfselect; >>> uint32_t gfselect; >>> -uint32_t guest_features[2]; >

Re: [PATCH RFC v2 06/13] virtio-pci: implement support for extended features

2025-07-15 Thread Paolo Abeni
On 7/15/25 9:42 AM, Akihiko Odaki wrote: > On 2025/07/11 22:02, Paolo Abeni wrote: >> @@ -158,7 +159,10 @@ struct VirtIOPCIProxy { >> uint32_t nvectors; >> uint32_t dfselect; >> uint32_t gfselect; >> -uint32_t guest_features[2]; >> +union { >> +uint32_t guest_featu

Re: [PATCH RFC v2 06/13] virtio-pci: implement support for extended features

2025-07-15 Thread Akihiko Odaki
On 2025/07/11 22:02, Paolo Abeni wrote: Extend the features configuration space to 128 bits, and allow the common read/write operation to access all of it. On migration, save the 128 bit version of the features only if the upper bits are non zero; after load zero the upper bits if the extended f

[PATCH RFC v2 06/13] virtio-pci: implement support for extended features

2025-07-11 Thread Paolo Abeni
Extend the features configuration space to 128 bits, and allow the common read/write operation to access all of it. On migration, save the 128 bit version of the features only if the upper bits are non zero; after load zero the upper bits if the extended features were not loaded. Note that we mus