Re: [PATCH RFC 00/32] python/qemu: refactor as installable package

2020-05-21 Thread John Snow
Ping, please give this series a look-over. It looks big, but the changes themselves are actually fairly tiny. Here's a TOC: Patch 1 moves files and renames import statements. Patches 2-3 do some basic delinting. Patches 4-5 do more basic delinting and add flake8/pylintrc cfg Patches 6-10 add setu

Re: [PATCH RFC 00/32] python/qemu: refactor as installable package

2020-05-18 Thread John Snow
On 5/18/20 8:41 AM, Philippe Mathieu-Daudé wrote: > On 5/14/20 7:53 AM, John Snow wrote: > >>    python//qmp.py: use True/False for non/blocking modes >>    python//qmp.py: Define common types >>    python//qmp.py: re-absorb MonitorResponseError >>    python//qmp.py: Do not return None from cmd

Re: [PATCH RFC 00/32] python/qemu: refactor as installable package

2020-05-18 Thread Philippe Mathieu-Daudé
On 5/14/20 7:53 AM, John Snow wrote: python//qmp.py: use True/False for non/blocking modes python//qmp.py: Define common types python//qmp.py: re-absorb MonitorResponseError python//qmp.py: Do not return None from cmd_obj python//qmp.py: add casts to JSON deserialization python

[PATCH RFC 00/32] python/qemu: refactor as installable package

2020-05-13 Thread John Snow
Hey, I got lost on my way to the store and I accidentally got 32 patches that convert our python library into something that passes pylint, flake8, and mypy --strict. ...So, a few things: 1. This is just an RFC. The actual design of these libraries really needs adjusted to be more pythonic. In ge