Re: [PATCH RFC] virtio-balloon: make it spec compliant

2024-07-09 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 05:15:18AM +0200, David Hildenbrand wrote: > On 04.07.24 23:30, Michael S. Tsirkin wrote: > > Currently, if VIRTIO_BALLOON_F_FREE_PAGE_HINT is off but > > VIRTIO_BALLOON_F_REPORTING is on, then the reporting vq > > gets number 3 while spec says it's number 4. > > It happens

Re: [PATCH RFC] virtio-balloon: make it spec compliant

2024-07-09 Thread David Hildenbrand
On 04.07.24 23:30, Michael S. Tsirkin wrote: Currently, if VIRTIO_BALLOON_F_FREE_PAGE_HINT is off but VIRTIO_BALLOON_F_REPORTING is on, then the reporting vq gets number 3 while spec says it's number 4. It happens to work because the linux virtio pci driver is *also* out of spec. To fix: 1. add

[PATCH RFC] virtio-balloon: make it spec compliant

2024-07-04 Thread Michael S. Tsirkin
Currently, if VIRTIO_BALLOON_F_FREE_PAGE_HINT is off but VIRTIO_BALLOON_F_REPORTING is on, then the reporting vq gets number 3 while spec says it's number 4. It happens to work because the linux virtio pci driver is *also* out of spec. To fix: 1. add vq4 as per spec 2. to help out the buggy Linux