Re: [PATCH RFC] meson: add option to use zstd for qcow2 compression by default

2021-07-01 Thread Vladimir Sementsov-Ogievskiy
17.06.2021 22:51, Vladimir Sementsov-Ogievskiy wrote: Recently we added support of zstd to qcow2 format, as zstd seems to be better than zlib in general, and which is important (as qcow2 compression used mostly for backups) compressed writes are faster with zstd. Let's add a build option to use

Re: [PATCH RFC] meson: add option to use zstd for qcow2 compression by default

2021-06-22 Thread Paolo Bonzini
On 22/06/21 12:16, Vladimir Sementsov-Ogievskiy wrote: Yes, this is more extensible. Looks good, I'll try. I'm just not familiar with it and followed the pattern of zstd option. You can look at -Dmalloc for an example. Paolo

Re: [PATCH RFC] meson: add option to use zstd for qcow2 compression by default

2021-06-22 Thread Vladimir Sementsov-Ogievskiy
21.06.2021 18:59, Kevin Wolf wrote: Am 21.06.2021 um 10:22 hat Paolo Bonzini geschrieben: On 17/06/21 21:51, Vladimir Sementsov-Ogievskiy wrote: So, it's an RFC. I also can split the patch so that refactoring of qcow2_co_create() go in a separate preparation patch. Another RFC question, should

Re: [PATCH RFC] meson: add option to use zstd for qcow2 compression by default

2021-06-21 Thread Kevin Wolf
Am 21.06.2021 um 10:22 hat Paolo Bonzini geschrieben: > On 17/06/21 21:51, Vladimir Sementsov-Ogievskiy wrote: > > So, it's an RFC. I also can split the patch so that refactoring of > > qcow2_co_create() go in a separate preparation patch. > > > > Another RFC question, shouldn't we move to zstd by

Re: [PATCH RFC] meson: add option to use zstd for qcow2 compression by default

2021-06-21 Thread Paolo Bonzini
On 17/06/21 21:51, Vladimir Sementsov-Ogievskiy wrote: So, it's an RFC. I also can split the patch so that refactoring of qcow2_co_create() go in a separate preparation patch. Another RFC question, shouldn't we move to zstd by default in upstream too? I think backwards-incompatible changes in

Re: [PATCH RFC] meson: add option to use zstd for qcow2 compression by default

2021-06-19 Thread Vladimir Sementsov-Ogievskiy
17.06.2021 22:51, Vladimir Sementsov-Ogievskiy wrote: Recently we added support of zstd to qcow2 format, as zstd seems to be better than zlib in general, and which is important (as qcow2 compression used mostly for backups) compressed writes are faster with zstd. Let's add a build option to use

[PATCH RFC] meson: add option to use zstd for qcow2 compression by default

2021-06-17 Thread Vladimir Sementsov-Ogievskiy
Recently we added support of zstd to qcow2 format, as zstd seems to be better than zlib in general, and which is important (as qcow2 compression used mostly for backups) compressed writes are faster with zstd. Let's add a build option to use zstd by default. Signed-off-by: Vladimir Sementsov-Ogie