Re: [PATCH RESEND v6 06/36] monitor: destaticize HMP commands

2020-04-23 Thread Philippe Mathieu-Daudé
On 4/23/20 5:07 PM, Jag Raman wrote: On Apr 23, 2020, at 10:14 AM, Philippe Mathieu-Daudé wrote: Why 'destaticize HMP commands’? Hi Philippe, Both QEMU & the remote process links the QMP code. QEMU uses all of the QMP commands, whereas, the remote process only uses a subset of this. Therefor

Re: [PATCH RESEND v6 06/36] monitor: destaticize HMP commands

2020-04-23 Thread Jag Raman
> On Apr 23, 2020, at 10:14 AM, Philippe Mathieu-Daudé > wrote: > > Why 'destaticize HMP commands’? Hi Philippe, Both QEMU & the remote process links the QMP code. QEMU uses all of the QMP commands, whereas, the remote process only uses a subset of this. Therefore, the ‘static’ functions wh

Re: [PATCH RESEND v6 06/36] monitor: destaticize HMP commands

2020-04-23 Thread Philippe Mathieu-Daudé
Why 'destaticize HMP commands'? On 4/23/20 6:13 AM, elena.ufimts...@oracle.com wrote: From: Jagannathan Raman Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Dr. David Alan Gilbert --- hmp-commands.hx| 4 +- monitor

[PATCH RESEND v6 06/36] monitor: destaticize HMP commands

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Dr. David Alan Gilbert --- hmp-commands.hx| 4 +- monitor/misc.c | 76 +++--- monitor/monitor-internal.h