Re: [PATCH RESEND v2 0/6] target/arm: Add nested virtualization support

2021-04-27 Thread Andrew Jones
On Tue, Apr 27, 2021 at 04:01:10PM +0100, Peter Maydell wrote: > On Tue, 27 Apr 2021 at 15:58, Peter Maydell wrote: > > > > On Tue, 27 Apr 2021 at 15:48, Andrew Jones wrote: > > > > > Since these types of features seem to blur the line between being a CPU > > > and board property, then I think I'

Re: [PATCH RESEND v2 0/6] target/arm: Add nested virtualization support

2021-04-27 Thread Peter Maydell
On Tue, 27 Apr 2021 at 15:48, Andrew Jones wrote: > Since these types of features seem to blur the line between being a CPU > and board property, then I think I'd prefer we call them CPU properties, > as they come from the CPU manual. Conversely, I prefer to call them board properties, because t

Re: [PATCH RESEND v2 0/6] target/arm: Add nested virtualization support

2021-04-27 Thread Peter Maydell
On Tue, 27 Apr 2021 at 15:58, Peter Maydell wrote: > > On Tue, 27 Apr 2021 at 15:48, Andrew Jones wrote: > > > Since these types of features seem to blur the line between being a CPU > > and board property, then I think I'd prefer we call them CPU properties, > > as they come from the CPU manual.

Re: [PATCH RESEND v2 0/6] target/arm: Add nested virtualization support

2021-04-27 Thread Andrew Jones
On Tue, Apr 27, 2021 at 01:15:24PM +0100, Peter Maydell wrote: > On Tue, 27 Apr 2021 at 10:55, Andrew Jones wrote: > > > > On Tue, Apr 27, 2021 at 10:42:18AM +0100, Peter Maydell wrote: > > > Why are we making the UI for "enable EL2 guest with KVM" different > > > from that for "enable EL2 guest w

Re: [PATCH RESEND v2 0/6] target/arm: Add nested virtualization support

2021-04-27 Thread Peter Maydell
On Tue, 27 Apr 2021 at 10:55, Andrew Jones wrote: > > On Tue, Apr 27, 2021 at 10:42:18AM +0100, Peter Maydell wrote: > > Why are we making the UI for "enable EL2 guest with KVM" different > > from that for "enable EL2 guest with TCG" ? Currently an EL2 > > TCG guest is set up with "-M virt,virtual

Re: [PATCH RESEND v2 0/6] target/arm: Add nested virtualization support

2021-04-27 Thread Andrew Jones
On Tue, Apr 27, 2021 at 10:42:18AM +0100, Peter Maydell wrote: > On Thu, 1 Apr 2021 at 13:55, Haibo Xu wrote: > > This series add support for ARMv8.3/8.4 nested virtualization support > > in KVM mode. It's based on Marc Zyngier's kernel KVM patches[1], and > > has been tested on a FVP model to run

Re: [PATCH RESEND v2 0/6] target/arm: Add nested virtualization support

2021-04-27 Thread Peter Maydell
On Thu, 1 Apr 2021 at 13:55, Haibo Xu wrote: > This series add support for ARMv8.3/8.4 nested virtualization support > in KVM mode. It's based on Marc Zyngier's kernel KVM patches[1], and > has been tested on a FVP model to run a L2 guest with Qemu. Now the > feature can be enabled by "-M virt,acc

Re: [PATCH RESEND v2 0/6] target/arm: Add nested virtualization support

2021-04-27 Thread Andrew Jones
On Thu, Apr 01, 2021 at 05:55:32AM -0700, Haibo Xu wrote: > v2: > - Move the NV to a CPU feature flag(Andrea&Andrew) > - Add CPU feature 'el2' test(Andrew) > > Many thanks to Andrea and Andrew for their comments! > > This series add support for ARMv8.3/8.4 nested virtualization support > in K

Re: [PATCH RESEND v2 0/6] target/arm: Add nested virtualization support

2021-04-01 Thread Andrea Bolognani
On Thu, 2021-04-01 at 12:55 +, Haibo Xu wrote: > v2: > - Move the NV to a CPU feature flag(Andrea&Andrew) > - Add CPU feature 'el2' test(Andrew) > > Many thanks to Andrea and Andrew for their comments! > > This series add support for ARMv8.3/8.4 nested virtualization support > in KVM mode

[PATCH RESEND v2 0/6] target/arm: Add nested virtualization support

2021-04-01 Thread Haibo Xu
v2: - Move the NV to a CPU feature flag(Andrea&Andrew) - Add CPU feature 'el2' test(Andrew) Many thanks to Andrea and Andrew for their comments! This series add support for ARMv8.3/8.4 nested virtualization support in KVM mode. It's based on Marc Zyngier's kernel KVM patches[1], and has been