Re: [PATCH 8.0 regression] block/nfs: do not poll within a coroutine

2023-04-12 Thread Kevin Wolf
Am 12.04.2023 um 13:26 hat Paolo Bonzini geschrieben: > Since the former nfs_get_allocated_file_size is now a coroutine > function, it must suspend rather than poll. Switch BDRV_POLL_WHILE() > to a qemu_coroutine_yield() loop and schedule nfs_co_generic_bh_cb() > in place of the call to bdrv_wakeu

Re: [PATCH 8.0 regression] block/nfs: do not poll within a coroutine

2023-04-12 Thread Eric Blake
On Wed, Apr 12, 2023 at 01:26:06PM +0200, Paolo Bonzini wrote: > Since the former nfs_get_allocated_file_size is now a coroutine > function, it must suspend rather than poll. Switch BDRV_POLL_WHILE() > to a qemu_coroutine_yield() loop and schedule nfs_co_generic_bh_cb() > in place of the call to b

Re: [PATCH 8.0 regression] block/nfs: do not poll within a coroutine

2023-04-12 Thread Peter Maydell
If you would like this in 8.0 then it needs to be reviewed and in a pullreq today... thanks -- PMM On Wed, 12 Apr 2023 at 12:27, Paolo Bonzini wrote: > > Since the former nfs_get_allocated_file_size is now a coroutine > function, it must suspend rather than poll. Switch BDRV_POLL_WHILE() > to a

[PATCH 8.0 regression] block/nfs: do not poll within a coroutine

2023-04-12 Thread Paolo Bonzini
Since the former nfs_get_allocated_file_size is now a coroutine function, it must suspend rather than poll. Switch BDRV_POLL_WHILE() to a qemu_coroutine_yield() loop and schedule nfs_co_generic_bh_cb() in place of the call to bdrv_wakeup(). Fixes: 82618d7bc341 ("block: Convert bdrv_get_allocated_