Re: [PATCH 8/9] rust: enable clippy::ptr_cast_constness

2025-05-02 Thread Paolo Bonzini
Il ven 2 mag 2025, 20:58 Stefan Zabka ha scritto: > Unrelated to the actual change, but a drive-by observation: > If you want to keep the MSRV in sync across all workspace members, you > could use workspace.package.rust-version to define it once and inherit > it everywhere. (Same goes for edition

Re: [PATCH 8/9] rust: enable clippy::ptr_cast_constness

2025-05-02 Thread Stefan Zabka
Unrelated to the actual change, but a drive-by observation: If you want to keep the MSRV in sync across all workspace members, you could use workspace.package.rust-version to define it once and inherit it everywhere. (Same goes for edition, license, and resolver.) https://doc.rust-lang.org/car

Re: [PATCH 8/9] rust: enable clippy::ptr_cast_constness

2025-05-02 Thread Paolo Bonzini
On Fri, May 2, 2025 at 1:13 PM Manos Pitsidianakis wrote: > msrv/rust-version bumps could instead go in the patch that also updates > meson.build version. Good idea, I was mistaken that ptr_cast_constness was already enabled by bumping them, but it's actually default-allow. Paolo

Re: [PATCH 8/9] rust: enable clippy::ptr_cast_constness

2025-05-02 Thread Manos Pitsidianakis
On Fri, 02 May 2025 13:23, Paolo Bonzini wrote: >Signed-off-by: Paolo Bonzini >--- > docs/devel/rust.rst | 2 -- > rust/Cargo.toml | 2 +- > rust/clippy.toml| 2 +- > rust/hw/char/pl011/Cargo.toml | 2 +- > rust/hw/timer/hpet/Cargo.toml | 2 +- > rust/hw

[PATCH 8/9] rust: enable clippy::ptr_cast_constness

2025-05-02 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/devel/rust.rst | 2 -- rust/Cargo.toml | 2 +- rust/clippy.toml| 2 +- rust/hw/char/pl011/Cargo.toml | 2 +- rust/hw/timer/hpet/Cargo.toml | 2 +- rust/hw/timer/hpet/src/hpet.rs | 2 +- rust/qemu-api-macros/Car