Re: [PATCH 7/9] util/vfio-helpers: Have qemu_vfio_dma_map() propagate Error

2021-08-25 Thread Klaus Jensen
On Aug 25 15:08, Philippe Mathieu-Daudé wrote: > On 8/25/21 1:34 PM, Klaus Jensen wrote: > > On Aug 24 16:11, Philippe Mathieu-Daudé wrote: > >> Now that all qemu_vfio_dma_map() callers provide an Error* argument, > >> fill it with relevant / more descriptive message. Reduce 'ret' > >> (returned va

Re: [PATCH 7/9] util/vfio-helpers: Have qemu_vfio_dma_map() propagate Error

2021-08-25 Thread Philippe Mathieu-Daudé
On 8/25/21 1:34 PM, Klaus Jensen wrote: > On Aug 24 16:11, Philippe Mathieu-Daudé wrote: >> Now that all qemu_vfio_dma_map() callers provide an Error* argument, >> fill it with relevant / more descriptive message. Reduce 'ret' >> (returned value) scope by returning errno directly to simplify >> (re

Re: [PATCH 7/9] util/vfio-helpers: Have qemu_vfio_dma_map() propagate Error

2021-08-25 Thread Klaus Jensen
On Aug 24 16:11, Philippe Mathieu-Daudé wrote: > Now that all qemu_vfio_dma_map() callers provide an Error* argument, > fill it with relevant / more descriptive message. Reduce 'ret' > (returned value) scope by returning errno directly to simplify > (removing the goto / 'out' label). > > Signed-of

[PATCH 7/9] util/vfio-helpers: Have qemu_vfio_dma_map() propagate Error

2021-08-24 Thread Philippe Mathieu-Daudé
Now that all qemu_vfio_dma_map() callers provide an Error* argument, fill it with relevant / more descriptive message. Reduce 'ret' (returned value) scope by returning errno directly to simplify (removing the goto / 'out' label). Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c| 1