Re: [PATCH 7/8] python/qapi: move scripts/qapi to python/qemu/qapi

2024-09-03 Thread John Snow
On Mon, Sep 2, 2024, 4:51 AM Daniel P. Berrangé wrote: > On Fri, Aug 30, 2024 at 02:22:50PM -0400, John Snow wrote: > > Gave Dan a related answer. For you, my explanation is: > > > > - It's nice to have just one configuration for static analysis in just > one > > place > > - It's nice to have tha

Re: [PATCH 7/8] python/qapi: move scripts/qapi to python/qemu/qapi

2024-09-02 Thread Peter Maydell
On Mon, 2 Sept 2024 at 09:51, Daniel P. Berrangé wrote: > > On Fri, Aug 30, 2024 at 02:22:50PM -0400, John Snow wrote: > > Gave Dan a related answer. For you, my explanation is: > > > > - It's nice to have just one configuration for static analysis in just one > > place > > - It's nice to have tha

Re: [PATCH 7/8] python/qapi: move scripts/qapi to python/qemu/qapi

2024-09-02 Thread Daniel P . Berrangé
On Fri, Aug 30, 2024 at 02:22:50PM -0400, John Snow wrote: > Gave Dan a related answer. For you, my explanation is: > > - It's nice to have just one configuration for static analysis in just one > place > - It's nice to have that configuration follow python ecosystem norms > - It's nice to use sta

Re: [PATCH 7/8] python/qapi: move scripts/qapi to python/qemu/qapi

2024-08-30 Thread John Snow
On Fri, Aug 30, 2024 at 7:20 AM Markus Armbruster wrote: > John Snow writes: > > > This is being done for the sake of unifying the linting and static type > > analysis configurations between scripts/qapi and python/qemu/*. > > > > With this change, the qapi module will now be checked by mypy, fl

Re: [PATCH 7/8] python/qapi: move scripts/qapi to python/qemu/qapi

2024-08-30 Thread John Snow
On Fri, Aug 30, 2024 at 7:29 AM Daniel P. Berrangé wrote: > On Fri, Aug 30, 2024 at 01:20:35PM +0200, Markus Armbruster wrote: > > John Snow writes: > > > > > This is being done for the sake of unifying the linting and static type > > > analysis configurations between scripts/qapi and python/qem

Re: [PATCH 7/8] python/qapi: move scripts/qapi to python/qemu/qapi

2024-08-30 Thread Daniel P . Berrangé
On Fri, Aug 30, 2024 at 01:20:35PM +0200, Markus Armbruster wrote: > John Snow writes: > > > This is being done for the sake of unifying the linting and static type > > analysis configurations between scripts/qapi and python/qemu/*. > > > > With this change, the qapi module will now be checked by

Re: [PATCH 7/8] python/qapi: move scripts/qapi to python/qemu/qapi

2024-08-30 Thread Markus Armbruster
John Snow writes: > This is being done for the sake of unifying the linting and static type > analysis configurations between scripts/qapi and python/qemu/*. > > With this change, the qapi module will now be checked by mypy, flake8, > pylint, isort etc under all python versions from 3.8 through 3

[PATCH 7/8] python/qapi: move scripts/qapi to python/qemu/qapi

2024-08-19 Thread John Snow
This is being done for the sake of unifying the linting and static type analysis configurations between scripts/qapi and python/qemu/*. With this change, the qapi module will now be checked by mypy, flake8, pylint, isort etc under all python versions from 3.8 through 3.13 under a variety of differ