Re: [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons

2020-06-16 Thread Philippe Mathieu-Daudé
On 6/16/20 2:29 PM, Peter Maydell wrote: > On Tue, 16 Jun 2020 at 11:40, Philippe Mathieu-Daudé wrote: >> On 6/16/20 12:27 PM, Peter Maydell wrote: >>> This change seems kind of pointless unless these GPIO lines are >>> actually wired up to something. >> >> Yes, I should have kept it out of this s

Re: [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons

2020-06-16 Thread Peter Maydell
On Tue, 16 Jun 2020 at 11:40, Philippe Mathieu-Daudé wrote: > On 6/16/20 12:27 PM, Peter Maydell wrote: > > This change seems kind of pointless unless these GPIO lines are > > actually wired up to something. > > Yes, I should have kept it out of this series, or documented > better the goal in the

Re: [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons

2020-06-16 Thread Philippe Mathieu-Daudé
On 6/16/20 12:27 PM, Peter Maydell wrote: > On Tue, 16 Jun 2020 at 07:32, Philippe Mathieu-Daudé wrote: >> >> The FPGA system control block has 2 push-buttons labelled PB0/PB1. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- > >> @@ -249,6 +258,8 @@ static void mps2_fpgaio_init(Object *obj) >

Re: [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons

2020-06-16 Thread Peter Maydell
On Tue, 16 Jun 2020 at 07:32, Philippe Mathieu-Daudé wrote: > > The FPGA system control block has 2 push-buttons labelled PB0/PB1. > > Signed-off-by: Philippe Mathieu-Daudé > --- > @@ -249,6 +258,8 @@ static void mps2_fpgaio_init(Object *obj) > memory_region_init_io(&s->iomem, obj, &mps2_fp

[PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons

2020-06-15 Thread Philippe Mathieu-Daudé
The FPGA system control block has 2 push-buttons labelled PB0/PB1. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/mps2-fpgaio.h | 1 + hw/misc/mps2-fpgaio.c | 13 - 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/include/hw/misc/mps2-fpgaio.h b/incl