Re: [PATCH 6/7] qapi: Split up scripts/qapi/common.py

2019-10-16 Thread Markus Armbruster
Kevin Wolf writes: > Am 01.10.2019 um 21:15 hat Markus Armbruster geschrieben: >> The QAPI code generator clocks in at some 3100 SLOC in 8 source files. >> Almost 60% of the code is in qapi/common.py. Split it into more >> focused modules: >> >> * Move QAPISchemaPragma and QAPISourceInfo to qap

Re: [PATCH 6/7] qapi: Split up scripts/qapi/common.py

2019-10-16 Thread Kevin Wolf
Am 01.10.2019 um 21:15 hat Markus Armbruster geschrieben: > The QAPI code generator clocks in at some 3100 SLOC in 8 source files. > Almost 60% of the code is in qapi/common.py. Split it into more > focused modules: > > * Move QAPISchemaPragma and QAPISourceInfo to qapi/source.py. > > * Move QAP

Re: [PATCH 6/7] qapi: Split up scripts/qapi/common.py

2019-10-02 Thread Markus Armbruster
Eric Blake writes: > On 10/2/19 10:16 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 10/1/19 2:15 PM, Markus Armbruster wrote: The QAPI code generator clocks in at some 3100 SLOC in 8 source files. Almost 60% of the code is in qapi/common.py. Split it into more focu

Re: [PATCH 6/7] qapi: Split up scripts/qapi/common.py

2019-10-02 Thread Eric Blake
On 10/2/19 10:16 AM, Markus Armbruster wrote: Eric Blake writes: On 10/1/19 2:15 PM, Markus Armbruster wrote: The QAPI code generator clocks in at some 3100 SLOC in 8 source files. Almost 60% of the code is in qapi/common.py. Split it into more focused modules: * Move QAPISchemaPragma and Q

Re: [PATCH 6/7] qapi: Split up scripts/qapi/common.py

2019-10-02 Thread Markus Armbruster
Eric Blake writes: > On 10/1/19 2:15 PM, Markus Armbruster wrote: >> The QAPI code generator clocks in at some 3100 SLOC in 8 source files. >> Almost 60% of the code is in qapi/common.py. Split it into more >> focused modules: >> >> * Move QAPISchemaPragma and QAPISourceInfo to qapi/source.py. >

Re: [PATCH 6/7] qapi: Split up scripts/qapi/common.py

2019-10-01 Thread Eric Blake
On 10/1/19 2:15 PM, Markus Armbruster wrote: The QAPI code generator clocks in at some 3100 SLOC in 8 source files. Almost 60% of the code is in qapi/common.py. Split it into more focused modules: * Move QAPISchemaPragma and QAPISourceInfo to qapi/source.py. * Move QAPIError and its sub-classe