Re: [PATCH 6/7] commit: Expose on-error option in QMP

2020-02-16 Thread Ján Tomko
On Fri, Feb 14, 2020 at 09:08:11PM +0100, Kevin Wolf wrote: Now that the error handling in the common block job is fixed, we can expose the on-error option in QMP instead of hard-coding it as 'report' in qmp_block_commit(). This fulfills the promise that the old comment in that function made, ev

[PATCH 6/7] commit: Expose on-error option in QMP

2020-02-14 Thread Kevin Wolf
Now that the error handling in the common block job is fixed, we can expose the on-error option in QMP instead of hard-coding it as 'report' in qmp_block_commit(). This fulfills the promise that the old comment in that function made, even if a bit later than expected: "This will be part of the QMP