Re: [PATCH 50/72] softfloat: Move minmax_flags to softfloat-parts.c.inc

2021-05-17 Thread Richard Henderson
On 5/17/21 8:14 AM, David Hildenbrand wrote: This patch introduces two issues: 1. Comparing two negative numbers is broken. We have to invert the a_less result. 2. The check "flags & minmax_ismag" is broken because "minmax_ismag = 4 | minmax_isnum" and it, therefore, also triggers for "flags =

Re: [PATCH 50/72] softfloat: Move minmax_flags to softfloat-parts.c.inc

2021-05-17 Thread David Hildenbrand
On 08.05.21 03:47, Richard Henderson wrote: Rename to parts$N_minmax. Combine 3 bool arguments to a bitmask, return a tri-state value to indicate nan vs unchanged operand. Introduce ftype_minmax functions as a common optimization point. Fold bfloat16 expansions into the same macro as the other t

[PATCH 50/72] softfloat: Move minmax_flags to softfloat-parts.c.inc

2021-05-07 Thread Richard Henderson
Rename to parts$N_minmax. Combine 3 bool arguments to a bitmask, return a tri-state value to indicate nan vs unchanged operand. Introduce ftype_minmax functions as a common optimization point. Fold bfloat16 expansions into the same macro as the other types. Signed-off-by: Richard Henderson ---