Re: [PATCH 5/8] util/compatfd.c: Replaced a malloc with GLib's variant

2021-03-15 Thread Alex Bennée
Thomas Huth writes: > On 15/03/2021 07.43, Mahmoud Mandour wrote: >> If it's unrelated, then maybe better do it in a separate patch. >> I thought so but I didn't know whether it was a so-small change >> that it didn't require its own patch or not. I will amend that. >> Since this is onl

Re: [PATCH 5/8] util/compatfd.c: Replaced a malloc with GLib's variant

2021-03-15 Thread Thomas Huth
On 15/03/2021 07.43, Mahmoud Mandour wrote: If it's unrelated, then maybe better do it in a separate patch. I thought so but I didn't know whether it was a so-small change that it didn't require its own patch or not. I will amend that. Since this is only a very small allocation, I thin

Re: [PATCH 5/8] util/compatfd.c: Replaced a malloc with GLib's variant

2021-03-14 Thread Mahmoud Mandour
> > If it's unrelated, then maybe better do it in a separate patch. > I thought so but I didn't know whether it was a so-small change that it didn't require its own patch or not. I will amend that. Since this is only a very small allocation, I think it would be better to > use g_malloc() here and

Re: [PATCH 5/8] util/compatfd.c: Replaced a malloc with GLib's variant

2021-03-14 Thread Thomas Huth
On 14/03/2021 04.23, Mahmoud Mandour wrote: Replaced a malloc() call and its respective free() call with GLib's g_try_malloc() and g_free(). Also, did slight styling changes that were producing style errors when using the checkpatch.pl script against the file. If it's unrelated, then maybe bet

[PATCH 5/8] util/compatfd.c: Replaced a malloc with GLib's variant

2021-03-13 Thread Mahmoud Mandour
Replaced a malloc() call and its respective free() call with GLib's g_try_malloc() and g_free(). Also, did slight styling changes that were producing style errors when using the checkpatch.pl script against the file. Signed-off-by: Mahmoud Mandour --- util/compatfd.c | 10 +- 1 file cha