Re: [PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants

Daniel P. Berrangé writes: > This allows us to include multiple QAPI schemas in the same file. > > Signed-off-by: Daniel P. Berrangé This commit prepends an optional prefix to generated uses of QAPI_FEATURE_{DEPRECATED,UNSTABLE}. It touches neither the handwritten definition in include/qapi/ut

Complications due to having multiple QAPI schemas (was: [PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants)

Markus Armbruster writes: > It's not just tests. QAPI-related headers have deteriorated, and pull > in too much. I'll try to clean this up. Thanks! While some cleanup is certainly possible and probably useful, I don't think I can completely solve the problem that way. Not counting tests, we

Re: [PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants

It's not just tests. QAPI-related headers have deteriorated, and pull in too much. I'll try to clean this up. Thanks!

Re: [PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants

Daniel P. Berrangé writes: > On Mon, Aug 05, 2024 at 03:11:12PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Mon, Aug 05, 2024 at 02:22:47PM +0200, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > This allows us to include multiple QAPI schem

Re: [PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants

On Mon, Aug 05, 2024 at 03:11:12PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Mon, Aug 05, 2024 at 02:22:47PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > This allows us to include multiple QAPI schemas in the same file. > >> > > >> > Si

Re: [PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants

Daniel P. Berrangé writes: > On Mon, Aug 05, 2024 at 02:22:47PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > This allows us to include multiple QAPI schemas in the same file. >> > >> > Signed-off-by: Daniel P. Berrangé >> >> I figure you had reason to simultaneously i

Re: [PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants

Daniel P. Berrangé writes: > This allows us to include multiple QAPI schemas in the same file. > > Signed-off-by: Daniel P. Berrangé I figure you had reason to simultaneously include headers generated for multiple schemas. Do tell :)

Re: [PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants

On Mon, Aug 05, 2024 at 02:22:47PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > This allows us to include multiple QAPI schemas in the same file. > > > > Signed-off-by: Daniel P. Berrangé > > I figure you had reason to simultaneously include headers generated for > multipl

[PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants

This allows us to include multiple QAPI schemas in the same file. Signed-off-by: Daniel P. Berrangé --- scripts/qapi/commands.py | 7 --- scripts/qapi/events.py | 3 ++- scripts/qapi/gen.py | 6 +++--- scripts/qapi/types.py| 5 +++-- scripts/qapi/visit.py| 5 +++-- 5 files cha