Re: [PATCH 5/5] linux-user: Do not align brk with host page size

2023-07-31 Thread Akihiko Odaki
On 2023/08/01 0:51, Helge Deller wrote: On 7/31/23 10:03, Akihiko Odaki wrote: do_brk() minimizes calls into target_mmap() by aligning the address with host page size, which is potentially larger than the target page size. Keep in mind, that host page size can be smaller than target page size

Re: [PATCH 5/5] linux-user: Do not align brk with host page size

2023-07-31 Thread Helge Deller
On 7/31/23 10:03, Akihiko Odaki wrote: do_brk() minimizes calls into target_mmap() by aligning the address with host page size, which is potentially larger than the target page size. Keep in mind, that host page size can be smaller than target page size too. That's the reason why host brk (brk_

[PATCH 5/5] linux-user: Do not align brk with host page size

2023-07-31 Thread Akihiko Odaki
do_brk() minimizes calls into target_mmap() by aligning the address with host page size, which is potentially larger than the target page size. However, the current implementation of this optimization has two bugs: - The start of brk is rounded up with the host page size while brk advertises an