Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions

2021-08-31 Thread Frédéric Pétrot
Hello Philippe, Le 30/08/2021 à 23:40, Philippe Mathieu-Daudé a écrit : > On 8/30/21 11:38 PM, Philippe Mathieu-Daudé wrote: >> On 8/30/21 7:16 PM, Frédéric Pétrot wrote: >>> Adding the support for the 128-bit arithmetic and logic instructions. >>> Remember that all (i) instructions are now acting

Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions

2021-08-30 Thread Richard Henderson
On 8/30/21 2:38 PM, Philippe Mathieu-Daudé wrote: +#if defined(TARGET_RISCV128) +if (is_128bit(ctx)) { Maybe this could allow the compiler eventually elide the code and avoid superfluous #ifdef'ry: if (TARGET_LONG_BITS >= 128) { TCG does not support TARGET_LONG_BITS != {3

Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions

2021-08-30 Thread Richard Henderson
On 8/30/21 10:16 AM, Frédéric Pétrot wrote: Adding the support for the 128-bit arithmetic and logic instructions. Remember that all (i) instructions are now acting on 128-bit registers, that a few others are added to cope with values that are held on 64 bits within the 128-bit registers, and that

Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions

2021-08-30 Thread Philippe Mathieu-Daudé
On 8/30/21 11:38 PM, Philippe Mathieu-Daudé wrote: > On 8/30/21 7:16 PM, Frédéric Pétrot wrote: >> Adding the support for the 128-bit arithmetic and logic instructions. >> Remember that all (i) instructions are now acting on 128-bit registers, that >> a few others are added to cope with values that

Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions

2021-08-30 Thread Philippe Mathieu-Daudé
On 8/30/21 7:16 PM, Frédéric Pétrot wrote: > Adding the support for the 128-bit arithmetic and logic instructions. > Remember that all (i) instructions are now acting on 128-bit registers, that > a few others are added to cope with values that are held on 64 bits within > the 128-bit registers, and

[PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions

2021-08-30 Thread Frédéric Pétrot
Adding the support for the 128-bit arithmetic and logic instructions. Remember that all (i) instructions are now acting on 128-bit registers, that a few others are added to cope with values that are held on 64 bits within the 128-bit registers, and that the ones that cope with values on 32-bit must