Re: [PATCH 4/7] commit: Inline commit_populate()

2020-02-16 Thread Ján Tomko
On Fri, Feb 14, 2020 at 09:08:09PM +0100, Kevin Wolf wrote: commit_populate() is a very short function and only called in a single place. Its return value doesn't tell us whether an error happened while reading or writing, which would be necessary for sending the right data in the BLOCK_JOB_ERROR

[PATCH 4/7] commit: Inline commit_populate()

2020-02-14 Thread Kevin Wolf
commit_populate() is a very short function and only called in a single place. Its return value doesn't tell us whether an error happened while reading or writing, which would be necessary for sending the right data in the BLOCK_JOB_ERROR QMP event. Signed-off-by: Kevin Wolf --- block/commit.c |