Re: [PATCH 4/6] sparc32-ledma: don't reference nd_table directly within the device

2020-09-26 Thread Mark Cave-Ayland
On 21/09/2020 18:58, Philippe Mathieu-Daudé wrote: > Sorry I guess I got confused by the 2 different sparc32_dma_init() > functions. > > Since ledma always expose lance, maybe you can use: > > diff --git a/hw/dma/sparc32_dma.c b/hw/dma/sparc32_dma.c > index 2cbe331959a..9a907a30373 100644 > ---

Re: [PATCH 4/6] sparc32-ledma: don't reference nd_table directly within the device

2020-09-26 Thread Mark Cave-Ayland
On 21/09/2020 18:14, Mark Cave-Ayland wrote: > On 21/09/2020 18:03, Mark Cave-Ayland wrote: > >> The lance and esp devices are embedded within ledma and espdma devices >> respectively, >> but are actually sysbus devices because they can be used by other machines. >> I'm not >> sure if lance is

Re: [PATCH 4/6] sparc32-ledma: don't reference nd_table directly within the device

2020-09-21 Thread Philippe Mathieu-Daudé
On 9/21/20 7:08 PM, Mark Cave-Ayland wrote: > On 21/09/2020 10:57, Philippe Mathieu-Daudé wrote: > >> Hi Mark, >> >> On 9/20/20 10:20 AM, Mark Cave-Ayland wrote: >>> Instead use qdev_set_nic_properties() to configure the on-board NIC at the >>> sun4m machine level. >>> >>> Signed-off-by: Mark Cave

Re: [PATCH 4/6] sparc32-ledma: don't reference nd_table directly within the device

2020-09-21 Thread Mark Cave-Ayland
On 21/09/2020 18:03, Mark Cave-Ayland wrote: > The lance and esp devices are embedded within ledma and espdma devices > respectively, > but are actually sysbus devices because they can be used by other machines. > I'm not > sure if lance is used anywhere else, but esp certainly is. Hence they ar

Re: [PATCH 4/6] sparc32-ledma: don't reference nd_table directly within the device

2020-09-21 Thread Mark Cave-Ayland
On 21/09/2020 10:57, Philippe Mathieu-Daudé wrote: > Hi Mark, > > On 9/20/20 10:20 AM, Mark Cave-Ayland wrote: >> Instead use qdev_set_nic_properties() to configure the on-board NIC at the >> sun4m machine level. >> >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/dma/sparc32_dma.c | 5 - >>

Re: [PATCH 4/6] sparc32-ledma: don't reference nd_table directly within the device

2020-09-21 Thread Mark Cave-Ayland
On 21/09/2020 10:25, Markus Armbruster wrote: > Mark Cave-Ayland writes: > >> Instead use qdev_set_nic_properties() to configure the on-board NIC at the >> sun4m machine level. >> >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/dma/sparc32_dma.c | 5 - >> hw/sparc/sun4m.c | 21 +++

Re: [PATCH 4/6] sparc32-ledma: don't reference nd_table directly within the device

2020-09-21 Thread Philippe Mathieu-Daudé
Hi Mark, On 9/20/20 10:20 AM, Mark Cave-Ayland wrote: > Instead use qdev_set_nic_properties() to configure the on-board NIC at the > sun4m machine level. > > Signed-off-by: Mark Cave-Ayland > --- > hw/dma/sparc32_dma.c | 5 - > hw/sparc/sun4m.c | 21 + > 2 files cha

Re: [PATCH 4/6] sparc32-ledma: don't reference nd_table directly within the device

2020-09-21 Thread Markus Armbruster
Mark Cave-Ayland writes: > Instead use qdev_set_nic_properties() to configure the on-board NIC at the > sun4m machine level. > > Signed-off-by: Mark Cave-Ayland > --- > hw/dma/sparc32_dma.c | 5 - > hw/sparc/sun4m.c | 21 + > 2 files changed, 13 insertions(+), 13 de

[PATCH 4/6] sparc32-ledma: don't reference nd_table directly within the device

2020-09-20 Thread Mark Cave-Ayland
Instead use qdev_set_nic_properties() to configure the on-board NIC at the sun4m machine level. Signed-off-by: Mark Cave-Ayland --- hw/dma/sparc32_dma.c | 5 - hw/sparc/sun4m.c | 21 + 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/hw/dma/sparc32_dm