Re: [PATCH 4/5] migration: refactor ram_save_target_page functions

2024-11-05 Thread Peter Xu
On Tue, Nov 05, 2024 at 03:31:19PM +0530, Prasad Pandit wrote: > On Mon, 4 Nov 2024 at 22:30, Peter Xu wrote: > > Yes, IMHO it's better when merged. > > > > One more note here, that even with ZERO_PAGE_DETECTION_MULTIFD, qemu will > > fallback to use LEGACY in reality when !multifd before. We nee

Re: [PATCH 4/5] migration: refactor ram_save_target_page functions

2024-11-05 Thread Prasad Pandit
On Mon, 4 Nov 2024 at 22:30, Peter Xu wrote: > Yes, IMHO it's better when merged. > > One more note here, that even with ZERO_PAGE_DETECTION_MULTIFD, qemu will > fallback to use LEGACY in reality when !multifd before. We need to keep > that behavior. * Where does this fallback happen? in ram_sav

Re: [PATCH 4/5] migration: refactor ram_save_target_page functions

2024-11-04 Thread Peter Xu
On Mon, Nov 04, 2024 at 05:26:45PM +0530, Prasad Pandit wrote: > On Fri, 1 Nov 2024 at 20:09, Peter Xu wrote: > > > +if (migrate_multifd()) { > > > +RAMBlock *block = pss->block; > > > +/* > > > + * While using multifd live migration, we still need to handle > > > zero

Re: [PATCH 4/5] migration: refactor ram_save_target_page functions

2024-11-04 Thread Prasad Pandit
On Fri, 1 Nov 2024 at 20:09, Peter Xu wrote: > > +if (migrate_multifd()) { > > +RAMBlock *block = pss->block; > > +/* > > + * While using multifd live migration, we still need to handle zero > > + * page checking on the migration main thread. > > + */ >

Re: [PATCH 4/5] migration: refactor ram_save_target_page functions

2024-11-01 Thread Peter Xu
On Tue, Oct 29, 2024 at 08:39:07PM +0530, Prasad Pandit wrote: > From: Prasad Pandit > > Refactor ram_save_target_page legacy and multifd > functions into one. Other than simplifying it, > it avoids reinitialization of the 'migration_ops' > object, when migration moves from multifd to postcopy >

[PATCH 4/5] migration: refactor ram_save_target_page functions

2024-10-29 Thread Prasad Pandit
From: Prasad Pandit Refactor ram_save_target_page legacy and multifd functions into one. Other than simplifying it, it avoids reinitialization of the 'migration_ops' object, when migration moves from multifd to postcopy phase. Signed-off-by: Prasad Pandit --- migration/ram.c | 54 +