Re: [PATCH 4/4] target/i386: move accel_cpu_instance_init to .instance_init

2025-07-10 Thread Paolo Bonzini
Il ven 11 lug 2025, 04:26 Xiaoyao Li ha scritto: > BTW, the user's value of "pmu" and "invtsc" are still broken for TDX > case. tdx_cpu_instance_init() will always overwrite "pmu" and "invtsc" > even if users explicitly request a different value via "-cpu" option. > > Will we leave it as intenti

Re: [PATCH 4/4] target/i386: move accel_cpu_instance_init to .instance_init

2025-07-10 Thread Zhao Liu
On Fri, Jul 11, 2025 at 02:06:03AM +0200, Paolo Bonzini wrote: > Date: Fri, 11 Jul 2025 02:06:03 +0200 > From: Paolo Bonzini > Subject: [PATCH 4/4] target/i386: move accel_cpu_instance_init to > .instance_init > X-Mailer: git-send-email 2.50.0 > > With the reordering

Re: [PATCH 4/4] target/i386: move accel_cpu_instance_init to .instance_init

2025-07-10 Thread Xiaoyao Li
On 7/11/2025 8:06 AM, Paolo Bonzini wrote: With the reordering of instance_post_init callbacks that is new in 10.1 accel_cpu_instance_init must execute in .instance_init as is already the case for RISC-V. Otherwise, for example, setting the vendor property is broken when using KVM or Hypervisor.

[PATCH 4/4] target/i386: move accel_cpu_instance_init to .instance_init

2025-07-10 Thread Paolo Bonzini
With the reordering of instance_post_init callbacks that is new in 10.1 accel_cpu_instance_init must execute in .instance_init as is already the case for RISC-V. Otherwise, for example, setting the vendor property is broken when using KVM or Hypervisor.framework, because KVM sets it *after* the us