Re: [PATCH 4/4] linux-user/arm: Fix identification of syscall numbers

2020-04-21 Thread Edgar E. Iglesias
On Mon, Apr 20, 2020 at 10:22:06PM +0100, Peter Maydell wrote: > Our code to identify syscall numbers has some issues: > * for Thumb mode, we never need the immediate value from the insn, >but we always read it anyway > * bad immediate values in the svc insn should cause a SIGILL, but we >

[PATCH 4/4] linux-user/arm: Fix identification of syscall numbers

2020-04-20 Thread Peter Maydell
Our code to identify syscall numbers has some issues: * for Thumb mode, we never need the immediate value from the insn, but we always read it anyway * bad immediate values in the svc insn should cause a SIGILL, but we were abort()ing instead (via "goto error") We can fix both these things