Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState

2024-01-30 Thread Philippe Mathieu-Daudé
On 30/1/24 12:05, Richard Henderson wrote: On 1/30/24 18:26, Philippe Mathieu-Daudé wrote: What is the rationale here? (I'm trying to generically understand in which case one is better than another). Didn't you ask Anton why a generic cpu_* function was using CPUArchState? Anyway, I think we'

Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState

2024-01-30 Thread Richard Henderson
On 1/30/24 18:26, Philippe Mathieu-Daudé wrote: What is the rationale here? (I'm trying to generically understand in which case one is better than another). Didn't you ask Anton why a generic cpu_* function was using CPUArchState? Anyway, I think we've generally used CPUState more often with g

Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState

2024-01-30 Thread Philippe Mathieu-Daudé
What is the rationale here? (I'm trying to generically understand in which case one is better than another). On 30/1/24 00:30, Richard Henderson wrote: Signed-off-by: Richard Henderson --- include/exec/cpu-all.h| 2 +- include/exec/cpu-common.h | 3 +-- target/sparc/cp

[PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState

2024-01-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/exec/cpu-all.h| 2 +- include/exec/cpu-common.h | 3 +-- target/sparc/cpu.h| 2 +- accel/tcg/cputlb.c| 22 +--- semihosting/uaccess.c | 2 +- target/cris/translate.c