Re: [PATCH 32/32] bsd-user: Implement pdfork(2) system call.

2023-08-29 Thread Warner Losh
On Tue, Aug 29, 2023 at 3:53 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/29/23 14:27, Warner Losh wrote: > > > +if (put_user_s32(fd, target_fdp)) { > > > +return -TARGET_EFAULT; > > > +} > > > > I *think* this copy belongs in the parent? >

Re: [PATCH 32/32] bsd-user: Implement pdfork(2) system call.

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/freebsd/os-proc.h| 32 bsd-user/freebsd/os-syscall.c | 4 2 files changed, 36 insertions(+) diff --git a/bsd-user/freebsd/os-pr

Re: [PATCH 32/32] bsd-user: Implement pdfork(2) system call.

2023-08-29 Thread Warner Losh
On Tue, Aug 29, 2023 at 2:58 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/27/23 08:57, Karim Taha wrote: > > From: Stacey Son > > > > Signed-off-by: Stacey Son > > Signed-off-by: Karim Taha > > --- > > bsd-user/freebsd/os-proc.h| 32 >

Re: [PATCH 32/32] bsd-user: Implement pdfork(2) system call.

2023-08-29 Thread Richard Henderson
On 8/29/23 14:27, Warner Losh wrote: > +    if (put_user_s32(fd, target_fdp)) { > +        return -TARGET_EFAULT; > +    } I *think* this copy belongs in the parent? I think that it's copied out in both cases. For normal fork, this would be 0 for the pid. However, it appears

[PATCH 32/32] bsd-user: Implement pdfork(2) system call.

2023-08-28 Thread Karim Taha
From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/freebsd/os-proc.h| 32 bsd-user/freebsd/os-syscall.c | 4 2 files changed, 36 insertions(+) diff --git a/bsd-user/freebsd/os-proc.h b/bsd-user/freebsd/os-proc.h index 9