Re: [PATCH 31/36] qdev: Stop using error_set_from_qdev_prop_error() for UUID property

2020-10-30 Thread Marc-André Lureau
On Fri, Oct 30, 2020 at 2:22 AM Eduardo Habkost wrote: > Just setting a reasonable error string using error_setg() is > simpler and makes error messages clearer. > > Before: > > $ qemu-system-x86_64 -device vmgenid,guid=x > qemu-system-x86_64: -device vmgenid,guid=x: Property 'vmgenid.guid' >

[PATCH 31/36] qdev: Stop using error_set_from_qdev_prop_error() for UUID property

2020-10-29 Thread Eduardo Habkost
Just setting a reasonable error string using error_setg() is simpler and makes error messages clearer. Before: $ qemu-system-x86_64 -device vmgenid,guid=x qemu-system-x86_64: -device vmgenid,guid=x: Property 'vmgenid.guid' doesn't take value 'x' After: $ qemu-system-x86_64 -device vmgeni