Re: [PATCH 3/7] migration: Refactor error handling in source return path

2023-06-28 Thread Fabiano Rosas
Peter Xu writes: > rp_state.error was a boolean used to show error happened in return path > thread. That's not only duplicating error reporting (migrate_set_error), > but also not good enough in that we only do error_report() and set it to > true, we never can keep a history of the exact error

[PATCH 3/7] migration: Refactor error handling in source return path

2023-06-28 Thread Peter Xu
rp_state.error was a boolean used to show error happened in return path thread. That's not only duplicating error reporting (migrate_set_error), but also not good enough in that we only do error_report() and set it to true, we never can keep a history of the exact error and show it in query-migrat