Re: [PATCH 3/4] qemu-img bitmap: Report errors while closing the image

2023-01-12 Thread Philippe Mathieu-Daudé
On 12/1/23 20:14, Kevin Wolf wrote: blk_unref() can't report any errors that happen while closing the image. For example, if qcow2 hits an -ENOSPC error while writing out dirty bitmaps when it's closed, it prints error messages to stderr, but 'qemu-img bitmap' won't see any error return value and

[PATCH 3/4] qemu-img bitmap: Report errors while closing the image

2023-01-12 Thread Kevin Wolf
blk_unref() can't report any errors that happen while closing the image. For example, if qcow2 hits an -ENOSPC error while writing out dirty bitmaps when it's closed, it prints error messages to stderr, but 'qemu-img bitmap' won't see any error return value and will therefore look successful with e