Re: [PATCH 3/4] char-socket: avoid double call tcp_chr_free_connection

2020-04-20 Thread Marc-André Lureau
Hi On Mon, Apr 20, 2020 at 5:10 AM Li Feng wrote: > > Hi Lureau, > > Thanks for your comment. > I have spent some time to reproduce this crash, so that delay my > reply, apologies. > > This is the description of this bug using gdb: > 1. Set break points using gdb; > b chardev/char-socket.c:410 if

Re: [PATCH 3/4] char-socket: avoid double call tcp_chr_free_connection

2020-04-19 Thread Li Feng
Hi Lureau, Thanks for your comment. I have spent some time to reproduce this crash, so that delay my reply, apologies. This is the description of this bug using gdb: 1. Set break points using gdb; b chardev/char-socket.c:410 if s->state == TCP_CHARDEV_STATE_DISCONNECTED b break vhost_user_write

Re: [PATCH 3/4] char-socket: avoid double call tcp_chr_free_connection

2020-04-15 Thread Marc-André Lureau
Hi On Wed, Apr 15, 2020 at 5:31 AM Li Feng wrote: > > double call tcp_chr_free_connection generates a crash. > > Signed-off-by: Li Feng Could you describe how you reach the "double call". Even better would be to write a test for it in tests/test-char.c thanks > --- > chardev/char-socket.c |

[PATCH 3/4] char-socket: avoid double call tcp_chr_free_connection

2020-04-14 Thread Li Feng
double call tcp_chr_free_connection generates a crash. Signed-off-by: Li Feng --- chardev/char-socket.c | 5 + 1 file changed, 5 insertions(+) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 185fe38dda..43aab8f24b 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket