Re: [External] Re: [PATCH 3/4] Implement zero page checking using DSA.

2023-05-30 Thread Hao Xiang
On Tue, May 30, 2023 at 2:26 AM Duan, Zhenzhong wrote: > > Hi Hao, > > > +memset(&descriptor, 0, sizeof(descriptor)); > > + > > +descriptor.opcode = DSA_OPCODE_COMPARE; > > What about using DSA_OPCODE_COMPVAL with zero? > DSA_OPCODE_COMPARE consumes double bandwidth by reading > from both

Re: [PATCH 3/4] Implement zero page checking using DSA.

2023-05-30 Thread Duan, Zhenzhong
Hi Hao, > +memset(&descriptor, 0, sizeof(descriptor)); > + > +descriptor.opcode = DSA_OPCODE_COMPARE; What about using DSA_OPCODE_COMPVAL with zero? DSA_OPCODE_COMPARE consumes double bandwidth by reading from both src and dest address. Thanks Zhenzhong

[PATCH 3/4] Implement zero page checking using DSA.

2023-05-29 Thread Hao Xiang
1. Adds a memory comparison function by submitting the work to the idxd driver. 2. Add interface to set bufferiszero accel function to DSA offloading. 3. Fallback to use CPU accel function if DSA offloading fails due to page fault. Signed-off-by: Hao Xiang --- include/qemu/cutils.h | 6 + migr