Re: [PATCH 3/3] target/mips: Simplify and fix update_pagemask

2025-03-31 Thread Philippe Mathieu-Daudé
On 28/3/25 18:55, Richard Henderson wrote: When update_pagemask was split from helper_mtc0_pagemask, we failed to actually write to the new parameter but continue to write to env->CP0_PageMask. Thus the use within page_table_walk_refill modifies cpu state and not the local variable as expected.

[PATCH 3/3] target/mips: Simplify and fix update_pagemask

2025-03-28 Thread Richard Henderson
When update_pagemask was split from helper_mtc0_pagemask, we failed to actually write to the new parameter but continue to write to env->CP0_PageMask. Thus the use within page_table_walk_refill modifies cpu state and not the local variable as expected. Simplify by renaming to compute_pagemask and