Re: [PATCH 3/3] hw/dma/xilinx_axidma.c: Switch to transaction-based ptimer API

2019-10-17 Thread Alistair Francis
On Thu, Oct 17, 2019 at 6:53 AM Peter Maydell wrote: > > Switch the xilinx_axidma code away from bottom-half based ptimers to > the new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_i

Re: [PATCH 3/3] hw/dma/xilinx_axidma.c: Switch to transaction-based ptimer API

2019-10-17 Thread Philippe Mathieu-Daudé
On 10/17/19 5:06 PM, Peter Maydell wrote: On Thu, 17 Oct 2019 at 16:01, Philippe Mathieu-Daudé wrote: Hi Peter, On 10/17/19 3:21 PM, Peter Maydell wrote: Switch the xilinx_axidma code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begi

Re: [PATCH 3/3] hw/dma/xilinx_axidma.c: Switch to transaction-based ptimer API

2019-10-17 Thread Peter Maydell
On Thu, 17 Oct 2019 at 16:01, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 10/17/19 3:21 PM, Peter Maydell wrote: > > Switch the xilinx_axidma code away from bottom-half based ptimers to > > the new transaction-based ptimer API. This just requires adding > > begin/commit calls around the va

Re: [PATCH 3/3] hw/dma/xilinx_axidma.c: Switch to transaction-based ptimer API

2019-10-17 Thread Philippe Mathieu-Daudé
Hi Peter, On 10/17/19 3:21 PM, Peter Maydell wrote: Switch the xilinx_axidma code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() fun

Re: [PATCH 3/3] hw/dma/xilinx_axidma.c: Switch to transaction-based ptimer API

2019-10-17 Thread Richard Henderson
On 10/17/19 6:21 AM, Peter Maydell wrote: > Switch the xilinx_axidma code away from bottom-half based ptimers to > the new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function

[PATCH 3/3] hw/dma/xilinx_axidma.c: Switch to transaction-based ptimer API

2019-10-17 Thread Peter Maydell
Switch the xilinx_axidma code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter Maydel