Re: [PATCH 3/3] accel/tcg: Fix jump cache set in cpu_exec_loop

2023-04-04 Thread Peter Maydell
On Sat, 1 Apr 2023 at 05:52, Richard Henderson wrote: > > Assign pc and use store_release to assign tb. > > Fixes: 2dd5b7a1b91 ("accel/tcg: Move jmp-cache `CF_PCREL` checks to caller") > Reported-by: Weiwei Li > Signed-off-by: Richard Henderson > --- > accel/tcg/cpu-exec.c | 17 +---

Re: [PATCH 3/3] accel/tcg: Fix jump cache set in cpu_exec_loop

2023-04-01 Thread Richard Henderson
On 4/1/23 04:03, liweiwei wrote:   mmap_unlock(); + Blank line. Yes, adding separation.   /*    * We add the TB in the virtual pc hash table    * for the fast lookup    */   h = tb_jmp_cache_hash_

Re: [PATCH 3/3] accel/tcg: Fix jump cache set in cpu_exec_loop

2023-04-01 Thread liweiwei
On 2023/4/1 12:51, Richard Henderson wrote: Assign pc and use store_release to assign tb. Fixes: 2dd5b7a1b91 ("accel/tcg: Move jmp-cache `CF_PCREL` checks to caller") Reported-by: Weiwei Li Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec.c | 17 + 1 file changed, 1

[PATCH 3/3] accel/tcg: Fix jump cache set in cpu_exec_loop

2023-03-31 Thread Richard Henderson
Assign pc and use store_release to assign tb. Fixes: 2dd5b7a1b91 ("accel/tcg: Move jmp-cache `CF_PCREL` checks to caller") Reported-by: Weiwei Li Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/acce