Re: [PATCH 27/30] build: move compiler version check to meson

2022-12-09 Thread Paolo Bonzini
On 12/9/22 15:19, Peter Maydell wrote: I think really I just don't want a check that is "we happen to know that this particular option switch is supported only from these versions onward", because as soon as we say "OK, we can move forward to a clang 7 baseline" we either need to search around fo

Re: [PATCH 27/30] build: move compiler version check to meson

2022-12-09 Thread Peter Maydell
On Fri, 9 Dec 2022 at 14:09, Paolo Bonzini wrote: > > On 12/9/22 12:52, Peter Maydell wrote: > > The new code makes it much harder to move our compiler version > > requirements forward in future, because there's no longer a simple > > "check for normal clang X or apple clang Y" test where we can >

Re: [PATCH 27/30] build: move compiler version check to meson

2022-12-09 Thread Paolo Bonzini
On 12/9/22 12:52, Peter Maydell wrote: The new code makes it much harder to move our compiler version requirements forward in future, because there's no longer a simple "check for normal clang X or apple clang Y" test where we can bump up X and Y based on what's provided in the various host platf

Re: [PATCH 27/30] build: move compiler version check to meson

2022-12-09 Thread Peter Maydell
On Fri, 9 Dec 2022 at 11:40, Paolo Bonzini wrote: > > Instead of checking with preprocessor defines, use the Meson compiler object. > Because of the mess Apple does with its versioning scheme, check for an > option that was added in clang 6.0 instead of looking at the version number. > -# Check w

[PATCH 27/30] build: move compiler version check to meson

2022-12-09 Thread Paolo Bonzini
Instead of checking with preprocessor defines, use the Meson compiler object. Because of the mess Apple does with its versioning scheme, check for an option that was added in clang 6.0 instead of looking at the version number. Signed-off-by: Paolo Bonzini --- configure | 25 ---