Re: [PATCH 21/27] target/ppc: cpu_init: Rename software TLB function

2022-02-15 Thread David Gibson
On Tue, Feb 15, 2022 at 06:41:42PM -0300, Fabiano Rosas wrote: > With the removal of the 7450 software TLB code, the only software TLBs > that we support currently are the 6xx and 7xx, so there's no need for > this function to indicate that in its name anymore. I don't think this is a good idea.

[PATCH 21/27] target/ppc: cpu_init: Rename software TLB function

2022-02-15 Thread Fabiano Rosas
With the removal of the 7450 software TLB code, the only software TLBs that we support currently are the 6xx and 7xx, so there's no need for this function to indicate that in its name anymore. Also, it's best to use a generic name for functions that are shared and only mention the specific CPU nam